View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000733||FreeCAD||Feature||public||2012-06-04 00:50||2012-06-08 16:56|
|Target Version||Fixed in Version||0.13|
|Summary||0000733: Up to first/last/face, two-sided dimension options for Pad Feature|
|Description||This will add the following options to the Pad feature:|
1. Extrude up to the first face found
2. Extrude up to the last face found
3. Extrude up to an arbitrary face the user chooses
4. Enter a second dimension to extrude in the other direction
There is also a demo part in there
|Tags||No tags attached.|
I have checked out your branch but it doesn't work for me. In your code I have found lines like Type.getValueAsString() == "TwoLengths". Note, the return value of getValueAsString() is a const char* not std::string and thus you mustn't use the == operator.
The easiest is to
std::string padType = Type.getValueAsString();
padType == "TwoLengths"
I'll fix it on my local branch from your branch and merge everything into master later.
Attached as a patch which fixes build errors on Windows and fixes the above issues.
I tried to rebase your branch to my master but I completely failed. I got dozens of merge conflicts and when trying to fix them git still complained about some of them. So, I gave up!
Yes, I had the same problems with the rebase, see
I think I will just delete everything and start over again with git...
||This part is included now.|
|2012-06-04 00:50||jrheinlaender||New Issue|
|2012-06-08 07:13||wmayer||Note Added: 0002153|
|2012-06-08 09:14||wmayer||File Added: partdesign.patch|
|2012-06-08 09:18||wmayer||Note Added: 0002154|
|2012-06-08 11:04||jrheinlaender||Note Added: 0002155|
|2012-06-08 16:56||wmayer||Note Added: 0002158|
|2012-06-08 16:56||wmayer||Status||new => closed|
|2012-06-08 16:56||wmayer||Resolution||open => fixed|
|2012-06-08 16:56||wmayer||Fixed in Version||=> 0.13|