View Issue Details

IDProjectCategoryView StatusLast Update
0003493Part[FreeCAD] Bugpublic2018-05-27 13:14
ReportermlampertAssigned Towmayer 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version[FreeCAD] 0.18 
Target Version[FreeCAD] 0.18Fixed in Version[FreeCAD] 0.18 
Summary0003493: Python Shape.isClosed() returns false for any solid, including primitive Parts
DescriptionCreating a box/sphere/cone/.... and call isClosed on the Shape of the object always returns false.
Steps To Reproducebox = Part.makeBox(10, 10, 10)
box.isClosed()
TagsNo tags attached.

Activities

wmayer

2018-05-27 13:14

administrator   ~0011285

According to the documentation the function does only something meaningful for shells, wires and edges and for all other shape types it only queries a flag but does not perform a geometric check.
[code=C++] //! If S is Shell, returns True if it has no free boundaries (edges). //! If S is Wire, returns True if it has no free ends (vertices). //! (Internal and External sub-shapes are ignored in these checks) //! If S is Edge, returns True if its vertices are the same. //! For other shape types returns S.Closed(). Standard_EXPORT static Standard_Boolean IsClosed (const TopoDS_Shape& S); [/code]

To make this function behave what the user expects it performs now the check for the shell of a solid.
See https://github.com/FreeCAD/FreeCAD/commit/0425c7f3c886e844cbdf405d27574bb93f2cf748

Issue History

Date Modified Username Field Change
2018-05-25 17:35 mlampert New Issue
2018-05-25 17:35 mlampert Status new => assigned
2018-05-25 17:35 mlampert Assigned To => mlampert
2018-05-25 21:50 mlampert Assigned To mlampert =>
2018-05-25 21:50 mlampert Status assigned => new
2018-05-25 21:50 mlampert Summary Cannot select existing solid as stock object => Python Shape.isClosed() returns false for any solid, including primitive Parts
2018-05-25 21:50 mlampert Description Updated View Revisions
2018-05-25 21:50 mlampert Steps to Reproduce Updated View Revisions
2018-05-25 21:50 mlampert Project Path => Part
2018-05-27 13:14 wmayer Note Added: 0011285
2018-05-27 13:14 wmayer Assigned To => wmayer
2018-05-27 13:14 wmayer Status new => closed
2018-05-27 13:14 wmayer Resolution open => fixed
2018-05-27 13:14 wmayer Fixed in Version => 0.18