View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002821||FreeCAD||Patch||public||2016-12-28 11:57||2018-11-05 18:29|
|Target Version||0.18||Fixed in Version|
|Summary||0002821: IDF Import of Step Models|
I'm using IDF module to import IDF Files written by Pulsonix.
I found that working with external Step models (by footprint_models.csv)
could be better.
The attached patch addresses three issues:
1. Difficulties in matching. I removed quotes from some strings
before using them
2. Read the step model now with Part.Shape.read() instead of using
ImportGui.insert(). This has the advantage to work even if the Step
Model has more than one solid/object.
3. Ability to hide/remove EMP generated models when a Step file for
a component was loaded. Without this you end up with the Step Model
and the EMP model overlap.
Although I tested with 0.16, the patch should apply to the current git.
Sorry I'm not a git user, and neither a Python programmer ...
|Additional Information||Forum thread: https://forum.freecadweb.org/viewtopic.php?f=8&t=31627|
|Tags||#pending, import, STEP|
Reminder sent to: shoogen
Hey @shoogen do you have a moment to address this ticket(patch) ? Thanks
||Note: @vejmarie will check this ticket soon.|
||changing to feedback to keep track of ticket.|
||@stefan.althoefer do you mind reattaching the .py script?|
||@vejmarie I can't get OP to respond. Can you take a look/see and offer yours opinion?|
||@vejmarie please weigh in. Can I close this ticket?|
Sorry for not having responded to all the pings. But here I'm back with
this issue. Mainly because I switched to 0.17 with the same issues and
had to recreate my patch.
The issues/improvements are exactly the same as in the original description.
My IDF looks like this:
With the original idf.py, the scanned input looked like this
Obviously, the double quote should be eliminated, or matching with external
step model files will not work.
My fix just replaces double quotes with nothing. It is very unlikely that double quotes will be part of the Component names. Perhaps it would be better to fix split_records()?
||I see that there is no demo IDF file set in the distribution. If you lack such thing for testing, I should be able to create one.|
||@stefan.althoefer can you submit a PR to https://github.com/FreeCAD/FreeCAD ?|
||@yorik care to weigh in on this ?|
||@Kunda1 regarding PR: Difficult, never did it before ...|
||@chrisb would you please test and/or make a PR from 0002821:0011498 ?|
||I have no idea of IDF and very little of STEP. I see only @vejmarie who can handle this.|
@stefan.althoefer I'm having issues applying the patch
Can you rebase it? I'll apply it once you do.
Also if you want to learn some quick and dirty 'git' check-out https://www.freecadweb.org/wiki/Source_code_management
||Added forum thread: https://forum.freecadweb.org/viewtopic.php?f=8&t=31627|
|2016-12-28 11:57||stefan.althoefer||New Issue|
|2016-12-28 11:57||stefan.althoefer||File Added: idf.py.patch|
|2017-01-17 20:43||Kunda1||Note Added: 0007854|
|2017-01-28 13:25||Kunda1||Note Added: 0008055|
|2017-01-28 13:26||Kunda1||Tag Attached: #pending|
|2017-03-23 23:57||Kunda1||Status||new => feedback|
|2017-03-23 23:57||Kunda1||Note Added: 0008693|
|2017-06-01 19:15||Kunda1||Note Added: 0009246|
|2017-06-16 15:55||Kunda1||Note Added: 0009415|
|2017-06-28 22:12||Kunda1||Note Added: 0009586|
|2017-07-11 20:19||Kunda1||Note Added: 0009719|
|2017-07-11 20:19||Kunda1||Tag Attached: import|
|2017-07-11 20:19||Kunda1||Tag Attached: STEP|
|2017-08-13 16:57||Kunda1||Note Added: 0009916|
|2017-09-24 19:29||Kunda1||Note Added: 0010173|
|2017-10-18 12:30||wmayer||Status||feedback => closed|
|2017-10-18 12:30||wmayer||Resolution||open => not fixable|
|2018-07-06 22:07||stefan.althoefer||Status||closed => feedback|
|2018-07-06 22:07||stefan.althoefer||Resolution||not fixable => reopened|
|2018-07-06 22:07||stefan.althoefer||Note Added: 0011498|
|2018-07-06 22:14||stefan.althoefer||Note Added: 0011499|
|2018-07-06 22:14||stefan.althoefer||Status||feedback => new|
|2018-07-08 15:15||Kunda1||Note Added: 0011500|
|2018-07-08 15:16||Kunda1||Note Added: 0011501|
|2018-07-09 21:01||stefan.althoefer||Note Added: 0011508|
|2018-07-10 13:59||Kunda1||Note Added: 0011511|
|2018-07-12 09:00||chrisb||Note Added: 0011514|
|2018-09-26 13:55||Kunda1||Note Added: 0011853|
|2018-10-17 20:16||Kunda1||Note Added: 0012047|
|2018-10-17 20:16||Kunda1||Status||new => feedback|
|2018-10-17 20:17||Kunda1||Description Updated||View Revisions|
|2018-10-17 20:18||Kunda1||Additional Information Updated||View Revisions|
|2018-10-17 20:19||Kunda1||Note Added: 0012048|
|2018-10-17 20:19||Kunda1||Target Version||=> 0.18|
|2018-10-19 13:21||Kunda1||Note Added: 0012067|
|2018-11-05 18:29||Kunda1||Note Added: 0012136|