View Issue Details

IDProjectCategoryView StatusLast Update
0000235FreeCADPatchpublic2011-01-13 09:54
Reportermyier Assigned Toyorik  
PrioritynormalSeverityminorReproducibilitysometimes
Status closedResolutionfixed 
Product Version0.12 
Target VersionFixed in Version0.11 
Summary0000235: [PATCH] rotate tool using keyboard input was broken
DescriptionWhile using the mouse, center point selection was possible, with the keyboard it wasn't. It seems that a method was renamed, but not everywhere in commit 3764 (see diff: http://free-cad.svn.sourceforge.net/viewvc/free-cad/trunk/src/Mod/Draft/draftTools.py?r1=3752&r2=3764&pathrev=3877). Patch follows:

--- draftTools.py (revision 3858)
+++ draftTools.py (working copy)
@@ -2270,7 +2270,7 @@
                "this function gets called by the toolbar when valid x, y, and z have been entered there"
                self.center = Vector(numx,numy,numz)
                self.node = [self.center]
- self.arctrack.centerPoint(self.center)
+ self.arctrack.setCenter(self.center)
                self.ghost.trans.center.setValue(self.center.x,self.center.y,self.center.z)
                self.linetrack.p1(self.center)
                self.arctrack.on()
TagsNo tags attached.
FreeCAD Information

Activities

myier

2011-01-09 13:37

reporter   ~0000492

There are several other errors in the code of the rotate keyboard handler:

- the centerPoint() method does not exist anymore, and may be fixed like this (I'm not sure if it's the right method):
- self.arctrack.centerPoint(self.center)
+ self.arctrack.setCenter(self.center)

- the fcvec.rotate() method has a different number of arguments now (and I don't know how to fix it):
  File "/opt/freecad-svn/Mod/Draft/draftTools.py", line 2288, in numericRadius
  self.arctrack.setStartAngle(fcvec.rotate(math.radians(rad)))
TypeError: rotate() takes at least 2 arguments (1 given)

yorik

2011-01-09 14:48

administrator   ~0000493

fixed in r3878. Thanks for reporting!

Issue History

Date Modified Username Field Change
2011-01-09 13:07 myier New Issue
2011-01-09 13:37 myier Note Added: 0000492
2011-01-09 14:22 yorik Status new => assigned
2011-01-09 14:22 yorik Assigned To => yorik
2011-01-09 14:48 yorik Note Added: 0000493
2011-01-09 14:48 yorik Status assigned => closed
2011-01-09 14:48 yorik Resolution open => fixed
2011-01-09 14:48 yorik Fixed in Version => 0.12
2011-01-13 09:54 Jriegel Fixed in Version 0.12 => 0.11