View Issue Details

IDProjectCategoryView StatusLast Update
0001319FreeCADBugpublic2014-05-10 09:48
Reporterwandererfan Assigned Towmayer  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Platformintel 64OSUbuntuOS Version12.04
Product Versiontrunk 
Summary0001319: Part.makeHelix Does Not Expose 2 Properties
DescriptionPart.makeHelix does not support the leftHanded and newStyle properties of TopoShape::makeHelix.
TagsNo tags attached.
FreeCAD Information

Activities

wandererfan

2013-11-29 21:06

manager  

helixParms.patch (Attachment missing)

wandererfan

2013-11-29 21:06

manager  

testmakeHelix.py (Attachment missing)

wandererfan

2013-11-29 21:08

manager   ~0003912

Last edited: 2014-04-27 20:44

helixParms.patch fixes Part.makeHelix to handle left handed and newstyle properties, and fixes the handling of left handed conical helices in TopoShape::makeHelix.

testmakeHelix.py is a test rig for the various parameter combinations.

wf

EDIT: helixParms.patch does NOT fix Part.makeLONGHelix. new fix on the way.

wandererfan

2014-04-27 20:45

manager   ~0004589

This was never merged, or fell out along the way.

wandererfan

2014-04-29 11:08

manager   ~0004593

Merge request submitted: http://www.forum.freecadweb.org/viewtopic.php?f=17&t=6437#p51916

Related Changesets

FreeCAD: master 33a4b6d7

2014-04-27 22:45:46

wandererfan


Committer: wmayer Details Diff
fixes 0001319
allow Part.makeHelix to use 'vertical height' parm
correct lefthanded conical helixes in TopoShape::makeHelix
Affected Issues
0001319
mod - src/Mod/Part/App/AppPartPy.cpp Diff File
mod - src/Mod/Part/App/TopoShape.cpp Diff File

Issue History

Date Modified Username Field Change
2013-11-29 18:32 wandererfan New Issue
2013-11-29 21:06 wandererfan File Added: helixParms.patch
2013-11-29 21:06 wandererfan File Added: testmakeHelix.py
2013-11-29 21:08 wandererfan Note Added: 0003912
2014-04-27 20:44 wandererfan Note Edited: 0003912
2014-04-27 20:44 wandererfan Note Edited: 0003912
2014-04-27 20:44 wandererfan Assigned To => wandererfan
2014-04-27 20:44 wandererfan Status new => assigned
2014-04-27 20:45 wandererfan Note Added: 0004589
2014-04-29 11:08 wandererfan Note Added: 0004593
2014-05-10 09:48 wmayer Changeset attached => FreeCAD Master master 33a4b6d7
2014-05-10 09:48 wmayer Assigned To wandererfan => wmayer
2014-05-10 09:48 wmayer Status assigned => closed
2014-05-10 09:48 wmayer Resolution open => fixed